fix: Fix order of arguments in IVariableMap.createVariable().#9231
Merged
fix: Fix order of arguments in IVariableMap.createVariable().#9231
IVariableMap.createVariable().#9231Conversation
cpcallen
approved these changes
Jul 14, 2025
Collaborator
cpcallen
left a comment
cpcallen
left a comment
There was a problem hiding this comment.
I think it might be worth adding a "NOT-QUITE-BREAKING CHANGE" note to the PR description, noting this is technically an API change but (a) the interface did not previously reflect the implementation, and (b) as parameters' types are not changing it (perhaps unfortunately) cannot cause any compilation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9218
Proposed Changes
This PR flips the names of the second and third arguments to
IVariableMap.createVariable()to reflect the ordering used in the built-inVariableMapclass.NOT-QUITE-BREAKING CHANGE
This PR changes the API, but (a) the previous interface was incorrect relative to the actual implementation provided, and the types of the arguments did not change. As a result, this will not result in build failures, but if you were using the old argument order your code wasn't doing what you intended.